Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R70 #870

Merged
merged 9 commits into from
Aug 24, 2021
Merged

Implement SIA-R70 #870

merged 9 commits into from
Aug 24, 2021

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 21, 2021

Resolves #826

#839 got botched with gazillion unrelated changes (likely messed up rebase from develop to main). Reaching the point where it's easier to light the copy/paste than to curse the rebase…

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Jul 21, 2021
@Jym77 Jym77 requested a review from kasperisager July 21, 2021 09:20
@Jym77 Jym77 mentioned this pull request Jul 21, 2021
Closed
@kasperisager kasperisager changed the title Implement SIA R70 Implement SIA-R70 Aug 2, 2021
kasperisager
kasperisager suggested changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits. Looks great! 👌

packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
kasperisager
kasperisager previously approved these changes Aug 24, 2021
View reviewed changes
@elenamongelli elenamongelli merged commit 170bb71 into main Aug 24, 2021
@elenamongelli elenamongelli deleted the sia-r70 branch August 24, 2021 14:21
kasperisager added a commit that referenced this pull request Sep 2, 2021
@kasperisager
Merge branch 'main' into tuple
5fafcb7 
* main: (21 commits)
  Implement SIA R76 (#910)
  Update CODEOWNERS
  Update `tar`
  Implement SIA-R109 (#901)
  Support `text-align` CSS property (#899)
  Implement SIA-R70 (#870)
  Implement SIA-R60 (#874)
  v0.21.2
  Update changelog
  Don't count invisible text as possibly wrapped in SIA-R83 (#898)
  Avoid test files being included by `yarn pack`
  v0.21.1
  Update changelog
  Reject empty text nodes in SIA-R75 (#896)
  Use separate concurrency groups for workflows
  Use `github.ref` instead of `github.head_ref`
  Limit concurrency of workflows
  Update API reviews
  Exclude `node_modules` in build scripts
  Mark `I` as `Readonly` in `Rule.Evaluate`
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elenamongelli elenamongelli elenamongelli left review comments

@kasperisager kasperisager kasperisager approved these changes

Assignees

@elenamongelli elenamongelli

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SIA-R70
3 participants
@Jym77 @kasperisager @elenamongelli